LX.NET Posted February 11 Share Posted February 11 I've added some additional code to the ser_open method, so it detects whether the comlynx cable is connected or not. lda IODAT and #NOEXP ; Check if redeye bit flag is unset beq redeye_ok lda #SER_ERR_NO_DEVICE ; ComLynx cable is not inserted ldx #0 rts Would this be useful to add to the new serial support implementation? What do you think? It might also be check only when relevant, e.g. when the handshake is hardware. It would be a bit of a misuse of the SER_HS_HW setting in the serial parameters, but it gives the option to check for it or not. Again, any opinions and advice welcome. Quote Link to comment Share on other sites More sharing options...
+karri Posted February 11 Author Share Posted February 11 It is really nice that you take the time to improve the serial tools. Adding the Lynx features to cc65 was done in a hurry and I had very little experience about ComLynx at the time. 1 Quote Link to comment Share on other sites More sharing options...
LX.NET Posted February 11 Share Posted February 11 (edited) Thanks @karri. I appreciate that coming from you. All, I have uploaded my code and submitted a pull request for this. Feel free to discuss and comment on the changes. https://github.com/cc65/cc65/pull/2410 Edit: the request has been made to verify the new code. Who can and wants to check it and comment at GitHub? @karri and @42bs, would you want to have a look at the code? Thanks! Edited February 11 by LX.NET 1 Quote Link to comment Share on other sites More sharing options...
42bs Posted February 11 Share Posted February 11 Checked it out, only a few comments, but honestly, I never used the COMLynx code for looooog time. 1 Quote Link to comment Share on other sites More sharing options...
LX.NET Posted February 11 Share Posted February 11 Thanks very much! I appreciate it very much. I made a single change to the code so far. I explained why the other things are as they are now. If you feel these should be changed, please let me know on GitHub. Thanks again. Quote Link to comment Share on other sites More sharing options...
LX.NET Posted February 13 Share Posted February 13 More changes were made and the pull request has been reviewed and approved. The code is emerged, so on a new build of cc65 and the lynx.lib library you will get the latest implementation for serial support. Thanks to @karri and @42bs for their support! Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.