Jump to content
IGNORED

ComLynx parity


karri

Recommended Posts

I've added some additional code to the ser_open method, so it detects whether the comlynx cable is connected or not.

 

        lda     IODAT
        and     #NOEXP                  ; Check if redeye bit flag is unset
        beq     redeye_ok
        lda     #SER_ERR_NO_DEVICE      ; ComLynx cable is not inserted
        ldx     #0
        rts

 

Would this be useful to add to the new serial support implementation? What do you think?

 

It might also be check only when relevant, e.g. when the handshake is hardware. It would be a bit of a misuse of the SER_HS_HW setting in the serial parameters, but it gives the option to check for it or not.

 

Again, any opinions and advice welcome.

Link to comment
Share on other sites

Thanks @karri. I appreciate that coming from you.

 

All, I have uploaded my code and submitted a pull request for this.

Feel free to discuss and comment on the changes.

 

https://github.com/cc65/cc65/pull/2410

 

Edit: the request has been made to verify the new code. Who can and wants to check it and comment at GitHub? @karri and @42bs, would you want to have a look at the code? Thanks!

Edited by LX.NET
  • Like 1
Link to comment
Share on other sites

Thanks very much! I appreciate it very much.

I made a single change to the code so far. I explained why the other things are as they are now. If you feel these should be changed, please let me know on GitHub.

Thanks again. 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Loading...
  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...