ComLynx parity

[LX.NET]

I've added some additional code to the ser_open method, so it detects whether the comlynx cable is connected or not.

 

        lda     IODAT
        and     #NOEXP                  ; Check if redeye bit flag is unset
        beq     redeye_ok
        lda     #SER_ERR_NO_DEVICE      ; ComLynx cable is not inserted
        ldx     #0
        rts

 

Would this be useful to add to the new serial support implementation? What do you think?

 

It might also be check only when relevant, e.g. when the handshake is hardware. It would be a bit of a misuse of the SER_HS_HW setting in the serial parameters, but it gives the option to check for it or not.

 

Again, any opinions and advice welcome.

[+karri]

It is really nice that you take the time to improve the serial tools. Adding the Lynx features to cc65 was done in a hurry and I had very little experience about ComLynx at the time.

[LX.NET]

Thanks @karri. I appreciate that coming from you.

 

All, I have uploaded my code and submitted a pull request for this.

Feel free to discuss and comment on the changes.

 

https://github.com/cc65/cc65/pull/2410

 

Edit: the request has been made to verify the new code. Who can and wants to check it and comment at GitHub? @karri and @42bs, would you want to have a look at the code? Thanks!

Edited February 11 by LX.NET

[42bs]

Checked it out, only a few comments, but honestly, I never used the COMLynx code for looooog time.

[LX.NET]

Thanks very much! I appreciate it very much.

I made a single change to the code so far. I explained why the other things are as they are now. If you feel these should be changed, please let me know on GitHub.

Thanks again. 

[LX.NET]

More changes were made and the pull request has been reviewed and approved. The code is emerged, so on a new build of cc65 and the lynx.lib library you will get the latest implementation for serial support. 

Thanks to @karri and @42bs for their support!