senior_falcon Posted April 28, 2015 Share Posted April 28, 2015 Now if the BASIC compiler supported disk access... Working on it.... 3 Quote Link to comment https://forums.atariage.com/topic/237458-to-optimize-or-to-scrap/page/3/#findComment-3227643 Share on other sites More sharing options...
Opry99er Posted May 5, 2015 Author Share Posted May 5, 2015 (edited) Well... it took several hours of work, but the following was accomplished today: *Eliminated 106 lines of code from my program *Completely re-wrote the ENTIRE Menu system (saving only labels) *Saved 2,138 BYTES of PROGRAM SPACE!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Wowza!!! Great feeling right now! Maintained 100% functionality... Only "downgrade" is there is a slight delay in displaying names of spells in the SPELLS menu... This is due to some fancy math and loops I put in there to READ from some DATA lines... Doing this saved me 32 lines of code, so I think I can live with it for now. I will take another look at it tomorrow and see if I can optimize it. So... Back to Topic title.... I SCRAPPED IT!!! Edited May 5, 2015 by Opry99er 3 Quote Link to comment https://forums.atariage.com/topic/237458-to-optimize-or-to-scrap/page/3/#findComment-3231726 Share on other sites More sharing options...
Opry99er Posted May 5, 2015 Author Share Posted May 5, 2015 (edited) How would you optimize this code to make it faster? It currently takes almost 3 seconds for whatever reason..... 2610 DISPLAY AT(15,1):" " 2620 RESTORE 3500 2630 FOR I=16 TO MN(C)+15 2640 READ TX$ 2650 DISPLAY AT(I,1):TX$; 2660 NEXT I . . 3500 DATA 1) HEAL (10 MP) 3510 DATA 2) CURE (15 MP) 3520 DATA 3) LIFE (20 MP) Edited May 5, 2015 by Opry99er Quote Link to comment https://forums.atariage.com/topic/237458-to-optimize-or-to-scrap/page/3/#findComment-3231972 Share on other sites More sharing options...
Opry99er Posted May 5, 2015 Author Share Posted May 5, 2015 **Background, it WAS a big long mess, wherein MN© was checked and control passed to one of 3 subroutines which displayed either 1,2, or all 3 of these... This was part of my rewrite to save bytes and simplify code. I may have gotten too "cute" with this one... Quote Link to comment https://forums.atariage.com/topic/237458-to-optimize-or-to-scrap/page/3/#findComment-3231984 Share on other sites More sharing options...
+adamantyr Posted May 5, 2015 Share Posted May 5, 2015 How would you optimize this code to make it faster? It currently takes almost 3 seconds for whatever reason..... 2610 DISPLAY AT(15,1):" " 2620 RESTORE 3500 2630 FOR I=16 TO MN(C)+15 2640 READ TX$ 2650 DISPLAY AT(I,1):TX$; 2660 NEXT I . . 3500 DATA 1) HEAL (10 MP) 3510 DATA 2) CURE (15 MP) 3520 DATA 3) LIFE (20 MP) Try removing the calculation from the FOR declaration... the easiest way is to determine how many you're going to display to start with, like follows: N = 3 + (MN© < 20) + (MN© < 15) + (MN© < 10) FOR I = 1 TO N ... The logic checks above will return 0 if the statement is false, and -1 if true. So if your magic points aren't high enough to cast any spells, N becomes 0 and the FOR loop is skipped entirely. Thinking back, most CRPG's would display ALL spells and just say "You don't have enough magic points" if you tried to pick one you didn't have enough for. That may be the best way to make this faster; just print them all and only do your magic point check AFTER the player has selected it. Quote Link to comment https://forums.atariage.com/topic/237458-to-optimize-or-to-scrap/page/3/#findComment-3232031 Share on other sites More sharing options...
Opry99er Posted May 5, 2015 Author Share Posted May 5, 2015 For sure... Thanks for the tips! In this case, however, the check is determining what to display depending in WHO will be casting (irrespective of MP)... This is where one player can cast 3 different spells, another two, and another just 1. Quote Link to comment https://forums.atariage.com/topic/237458-to-optimize-or-to-scrap/page/3/#findComment-3232066 Share on other sites More sharing options...
Opry99er Posted May 5, 2015 Author Share Posted May 5, 2015 (edited) MN (meaning magic number) indicates the number (0-3) of spells a member can cast. It is an array with 4 values... In this case, I want to ONLY display the castable magics of each player, so I used this formula. The FOR I=16 TO MN©+15 is simply to give me the proper number of.times through the loop, while using "I" as the row for display. Like I said, I may have gotten too cute... It works well, but at what cost? Edited May 5, 2015 by Opry99er Quote Link to comment https://forums.atariage.com/topic/237458-to-optimize-or-to-scrap/page/3/#findComment-3232067 Share on other sites More sharing options...
Opry99er Posted May 5, 2015 Author Share Posted May 5, 2015 Thinking back, most CRPG's would display ALL spells and just say "You don't have enough magic points" if you tried to pick one you didn't have enough for. That may be the best way to make this faster; just print them all and only do your magic point check AFTER the player has selected it. That's how I do it too. Quote Link to comment https://forums.atariage.com/topic/237458-to-optimize-or-to-scrap/page/3/#findComment-3232072 Share on other sites More sharing options...
+adamantyr Posted May 5, 2015 Share Posted May 5, 2015 MN (meaning magic number) indicates the number (0-3) of spells a member can cast. It is an array with 4 values... In this case, I want to ONLY display the castable magics of each player, so I used this formula. The FOR I=16 TO MN©+15 is simply to give me the proper number of.times through the loop, while using "I" as the row for display. Like I said, I may have gotten too cute... It works well, but at what cost? Ahh... in that case, remove your 16 and +15 from the FOR loop, and just put that into the DISPLAY AT instead. That way it's only pulling the reference and not actually doing calculations. That may get you back a bit of performance. Quote Link to comment https://forums.atariage.com/topic/237458-to-optimize-or-to-scrap/page/3/#findComment-3232073 Share on other sites More sharing options...
Opry99er Posted May 5, 2015 Author Share Posted May 5, 2015 (edited) Thanks... I guess I am just struggling with how to get it to display the proper number of lines then... If my mage is the ©, then I need three times through the loop... If thief, then I only need 2, etc. Something like X=16 FOR I= 1 TO MN© READ TX$ DISPLAY AT(X,1):TX$; X=X+1 NEXT I Would this net some speed, you think? Edited May 5, 2015 by Opry99er Quote Link to comment https://forums.atariage.com/topic/237458-to-optimize-or-to-scrap/page/3/#findComment-3232075 Share on other sites More sharing options...
+Lee Stewart Posted May 5, 2015 Share Posted May 5, 2015 The loop limit is only evaluated once, so I would not think that is the bottleneck. I Think the READ, with the possible invocation of garbage collection in VRAM, is what is taking the time. I would bet you would get a speed increase by using a string array instead of the DATA statements. Of course, that moves storage to VRAM (I think) instead of program storage. ...lee Quote Link to comment https://forums.atariage.com/topic/237458-to-optimize-or-to-scrap/page/3/#findComment-3232083 Share on other sites More sharing options...
JamesD Posted May 5, 2015 Share Posted May 5, 2015 Thanks... I guess I am just struggling with how to get it to display the proper number of lines then... If my mage is the ©, then I need three times through the loop... If thief, then I only need 2, etc. Something like X=16 FOR I= 1 TO MN© READ TX$ DISPLAY AT(X,1):TX$; X=X+1 NEXT I Would this net some speed, you think? Check to see if this is faster, I have no idea: X = MN(C) + 15 FOR I= 16 TO X READ TX$ DISPLAY AT(I,1):TX$; NEXT I But I would write it like this if TI BASIC lets you. There is some overhead involved with added line numbers. X = MN(C) + 15 FOR I= 16 TO X :: READ TX$ :: DISPLAY AT(I,1):TX$; :: NEXT I Quote Link to comment https://forums.atariage.com/topic/237458-to-optimize-or-to-scrap/page/3/#findComment-3232087 Share on other sites More sharing options...
Opry99er Posted May 5, 2015 Author Share Posted May 5, 2015 Thanks for the ideas, guys. I think the most likely culprit, as Lee suggested, is the READ. I will try out all the suggestions you guys have given me, but my money is on a string array for optimum speed increase. Once again, you guys rock. Quote Link to comment https://forums.atariage.com/topic/237458-to-optimize-or-to-scrap/page/3/#findComment-3232110 Share on other sites More sharing options...
JamesD Posted May 5, 2015 Share Posted May 5, 2015 Read has to scan through the lines looking for the data statement at least at the first read.If TI supports RESTORE (I think that's the command) you can RESTORE # and then BASIC should know where the data is.In theory... I've never tried it Quote Link to comment https://forums.atariage.com/topic/237458-to-optimize-or-to-scrap/page/3/#findComment-3232136 Share on other sites More sharing options...
+InsaneMultitasker Posted May 5, 2015 Share Posted May 5, 2015 Owen - string arrays are pretty handy. Most of Heatwave's prompts and text are located in one string array for quick and easy access. When the BBS starts up, it loads all 100+ strings from a single dis/var80 file, editable in FunnelWeb (or any similar editor). You can print the DV80 file with line numbers using the "L" option, if I recall correctly, so that you can reference the string array numbers. If you have string space to spare, this might be a good alternative for you. It would also free up precious programming space. Quick and dirty load from DV80 file: 10 DIM A$(100) !space for up to 100 lines in the file 100 OPEN #99:"DSK1.YOURDV80",INPUT 110 A=0 120 A=A+1 :: LINPUT #99:A$(A)::IF EOF(99)<>1 THEN 120 130 CLOSE #99 140 FOR X=1 TO A::PRINT A$(X)::NEXT X Note: LINPUT is used here in case commas or other delimiters are found in your string. 1 Quote Link to comment https://forums.atariage.com/topic/237458-to-optimize-or-to-scrap/page/3/#findComment-3232138 Share on other sites More sharing options...
Opry99er Posted May 5, 2015 Author Share Posted May 5, 2015 @James: Yea, I am using RESTORE in this code. I think the whole segment is third post from the top of the page. These are currently my only DATA lines, so initially I didn't have a RESTORE. But, seeing the speed problem, (just like you suggested) I added RESTORE... It did not seem to speed up execution by much if at all. @Tim: Yessir!!! I have recently discovered the magic of arrays, string and numeric! Currently all my data (other than the current DATA lines I am struggling to manipulate) is drawn from a DV file on disk. My disk code looks much like yours there, only without the EOF part... I am referencing the records in a loop and just feeding them directly into my numeric and string arrays at the start of the program. Really is cool... Quote Link to comment https://forums.atariage.com/topic/237458-to-optimize-or-to-scrap/page/3/#findComment-3232143 Share on other sites More sharing options...
+InsaneMultitasker Posted May 5, 2015 Share Posted May 5, 2015 Currently all my data (other than the current DATA lines I am struggling to manipulate) is drawn from a DV file on disk. Well then, sounds like your next test is to stick those lines in a string array to check out the speed difference If you like the results, add those lines to your DV80 file and don't look back Quote Link to comment https://forums.atariage.com/topic/237458-to-optimize-or-to-scrap/page/3/#findComment-3232184 Share on other sites More sharing options...
Opry99er Posted May 6, 2015 Author Share Posted May 6, 2015 Soon as I get home, brotha... Ill test the other ones too... I am interested in the speed differences and the "why's"... Good to note for future reference. Quote Link to comment https://forums.atariage.com/topic/237458-to-optimize-or-to-scrap/page/3/#findComment-3232308 Share on other sites More sharing options...
Willsy Posted May 6, 2015 Share Posted May 6, 2015 How would you optimize this code to make it faster? It currently takes almost 3 seconds for whatever reason..... 2610 DISPLAY AT(15,1):" " 2620 RESTORE 3500 2630 FOR I=16 TO MN(C)+15 2640 READ TX$ 2650 DISPLAY AT(I,1):TX$; 2660 NEXT I . . 3500 DATA 1) HEAL (10 MP) 3510 DATA 2) CURE (15 MP) 3520 DATA 3) LIFE (20 MP) If there's only three spells then you might as well use a string. Since the strings are all the same length (15 characters) it's nice and simple. This code takes about 0.75 seconds to display: 3500 spell$="1) HEAL (10 MP)2) CURE (15 MP)3) LIFE (20 MP)" 3510 for i=0 to 2 3520 display at(I+1,1):seg$(spell$,(i*15)+1,15); 3530 next i Yeah baby. I still got my XB chops Quote Link to comment https://forums.atariage.com/topic/237458-to-optimize-or-to-scrap/page/3/#findComment-3232475 Share on other sites More sharing options...
Opry99er Posted May 6, 2015 Author Share Posted May 6, 2015 (edited) ^^LOL^^ Loop starting with a "0"... You damn real programmers with your real programming skills and sh**... The Forth is strong with this one... Thanks Willsy. Edited May 6, 2015 by Opry99er Quote Link to comment https://forums.atariage.com/topic/237458-to-optimize-or-to-scrap/page/3/#findComment-3232477 Share on other sites More sharing options...
Opry99er Posted May 6, 2015 Author Share Posted May 6, 2015 (edited) BTW, there is a fourth (forth) spell... I have not named it yet, but it is likely to be named "ALL-HEAL"... The reason it is not listed yet (or implemented) is that it is more costly than anyone can afford yet (MP-wise) The mage will have to be at level 4 or higher to have enough MP to cast it. That wrenches the 15 char seg., but I love the idea of one string segmented out... I was thinking string array, but your method is pretty slick. Since nothing is displayed AFTER the MP cost, maybe we could just pad the first three to have 19 characters (four trailing spaces) Edited May 6, 2015 by Opry99er Quote Link to comment https://forums.atariage.com/topic/237458-to-optimize-or-to-scrap/page/3/#findComment-3232480 Share on other sites More sharing options...
Tursi Posted May 6, 2015 Share Posted May 6, 2015 A string array would have a few advantages - the biggest is garbage collection. Chopping the string up with SEG$ makes a new temporary string every time - once free VRAM is filled, the code will stop and force a garbage collection to clean up the unused memory. With a string array you aren't changing the strings, so there's no temporary string created, so less garbage collection (as well as displaying faster because there's no processing either). 1 Quote Link to comment https://forums.atariage.com/topic/237458-to-optimize-or-to-scrap/page/3/#findComment-3232495 Share on other sites More sharing options...
Willsy Posted May 6, 2015 Share Posted May 6, 2015 Nice one Yoda, er, Tursi, the TI programming guru! 1 Quote Link to comment https://forums.atariage.com/topic/237458-to-optimize-or-to-scrap/page/3/#findComment-3232501 Share on other sites More sharing options...
Willsy Posted May 6, 2015 Share Posted May 6, 2015 That wrenches the 15 char seg., but I love the idea of one string segmented out... I was thinking string array, but your method is pretty slick. Since nothing is displayed AFTER the MP cost, maybe we could just pad the first three to have 19 characters (four trailing spaces) Aye. That'll work, however see Yoda's Tursi's post re garbage collection... something to bear in mind. A single string takes up less program space than declaring three strings, and will be a little faster (probably) but it could/will induce a garbage collection once in a while where your program will pause for 1 or 2 seconds. Quote Link to comment https://forums.atariage.com/topic/237458-to-optimize-or-to-scrap/page/3/#findComment-3232502 Share on other sites More sharing options...
Willsy Posted May 6, 2015 Share Posted May 6, 2015 Loop starting with a "0"... You damn real programmers with your real programming skills and sh**... It makes much more sense to start from 0. If I started from 1 I'd have to do: 3520 display at(I,1):seg$(spell$,((i-1)*15)+1,15); Which seems unneccesarily complex to me! 1 Quote Link to comment https://forums.atariage.com/topic/237458-to-optimize-or-to-scrap/page/3/#findComment-3232504 Share on other sites More sharing options...
Like us on Facebook
Follow us on Twitter
AtariAge on Instagram
Watch us on YouTube
Chat on Discord
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.